Skip to content

Conversation

@michalsn
Copy link
Member

Description
This PR ignores two Rector rules which were added in the latest versions.

I believe that the application of these rules will negatively affect the readability of our tests.

Here are the proposed changes in the codebase by Rector: https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890

I'm not super convinced about it - this was just my first impression.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Collaborator

I see this change as fair and reasonable.

@michalsn michalsn merged commit 58d6d6f into codeigniter4:develop Feb 11, 2025
28 checks passed
@michalsn
Copy link
Member Author

Thanks for the review guys!

@michalsn michalsn deleted the fix/rector branch February 11, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants